Sakai Vault
Sakai Vault is a decentralized spot and perpetual exchange that supports low swap fees and zero price impact trades. Trading is supported by a unique multi-asset pool that earns liquidity providers fees from market making, swap fees and leverage trading. Sakai Vault is a next crypto revolution and it is Accelerates DeFi Adoption With Trusted Blockchain Protocol and Unique Token Economics Sakai Vault Provides its customers and investors with insights on trends and developments in the crypto space. We provide an in-depth look at selected topics ranging from cryptocurrency fundamentals to market analyses and help to grow your investment with us.
Owner privileges
Comments
Owner privileges
- set base uri
- set vault address
- By setting the vault address to an arbitrary address the owner can prevent the execution of mint and buyback functionality. Additionally, the owner can set the vaultAddress to an EOA address and mint new tokens to arbitrary addresses.
- set token uri
Note - This Audit report consists of a security analysis of the Sakai Vault smart contract. This analysis did not include functional testing (or unit testing) of the contract’s logic. Moreover, we only audited one token contract for the Sakai Vault team. Other contracts associated with the project were not audited by our team. We recommend investors do their own research before investing.
Audit Scope
This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.
We will verify the following claims:- Correct implementation of Token standard
- Deployer cannot mint any new tokens
- Deployer cannot burn or lock user funds
- Deployer cannot pause the contract
- Overall checkup (Smart Contract Security)
- Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
- Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
- Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
- Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
- Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
- Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
- Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.
A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.
Functions
public
45
State variables
public
1
Total lines
of code
1758
Capabilities
Hover on items
Audit Details
Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to speciïŹcation and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.
Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.
low Issues
Pending
#1 Issue
Local variables shadowing (shadowing-local)
L1746
Rename the local variables that shadow another component.
Pending
#2 Issue
Missing Zero Address Validation (missing-zero-check)
L1711
Check that the address is not zero.
Pending
#3 Issue
VaultAddress can be set to zero address
L1711
The owner can set the vault address to the zero/dead address. That causes the vault protocol cannot call the mintNFT, buyback function etc., anymore. Additionally, check that the vault address is a contract address.
informational Issues
Pending
#1 Issue
Functions that are not used (dead-code)
L800-812
L658-660
L668-674
L687-689
L697-706
L739-741
L749-756
L714-716
L724-731
L633-638
L788-798
L764-780
L488-490
L1527-1529
L1169-1171
L1363-1384
L1300-1302
L1308-1314
L79-82
L90-93
L335-340
L244-280
L286-291
L348-372
L378-383
L64-66
L71-73
L100-179
L184-190
L197-228
L233-238
L39-44
L30-34
L15-17
L22-24
L464-466
L457-459
L433-437
L442-452
L426-428
Remove unused functions.
Pending
#2 Issue
Unused return values (unused-return)
L1463-1485
Ensure that all the return values of the function calls are used.
optimization Issues
Pending
#1 Issue
Public function that could be declared external (external-function)
L549-551
L557-560
L1143-1145
L1150-1152
L1157-1162
L1176-1186
L1200-1202
L1214-1219
L1224-1226
L1577-1580
Use the `external` attribute for functions never called from the contract.
Diagrams
Disclaimer
SolidProof.io reports are not, nor should be considered, an âendorsementâ or âdisapprovalâ of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any âproductâ or âassetâ created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etcâ...)
SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.
SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProofâs position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.