Sakai Vault
Sakai Vault is a decentralized spot and perpetual exchange that supports low swap fees and zero price impact trades. Trading is supported by a unique multi-asset pool that earns liquidity providers fees from market making, swap fees and leverage trading. Sakai Vault is a next crypto revolution and it is Accelerates DeFi Adoption With Trusted Blockchain Protocol and Unique Token Economics Sakai Vault Provides its customers and investors with insights on trends and developments in the crypto space. We provide an in-depth look at selected topics ranging from cryptocurrency fundamentals to market analyses and help to grow your investment with us.
Owner privileges
Comments
Owner privileges
- reset eligible
- only if the current timestamp is higher than the "endingAt" variable
- stop eligible
- only if the current timestamp is higher than the "endingAt" variable
- by setting the "startingAt" variable to 0, nobody can execute the "buy" function anymore
- update the price per ticket
- this can be set to any arbitrary value
- Enable/disable auto pick winner
- update eligible day
- any arbitrary value is possible
- update committed token address
- update staking address
- update charity address
- update router address
- update busd address
- update nft address
- update percent winner
- update percent tax claim
- staking + charity <= 25%
- execute the pick winners function manually
The owner can lock user funds by setting an arbitrary address for the nft. That causes the nft contract functions are not callable anymore.
Note - This Audit report consists of a security analysis of the Sakai Vault smart contract. This analysis did not include functional testing (or unit testing) of the contract’s logic. Moreover, we only audited one token contract for the Sakai Vault team. Other contracts associated with the project were not audited by our team. We recommend investors do their own research before investing.
Audit Scope
This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.
We will verify the following claims:- Correct implementation of Token standard
- Deployer cannot mint any new tokens
- Deployer cannot burn or lock user funds
- Deployer cannot pause the contract
- Overall checkup (Smart Contract Security)
- Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
- Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
- Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
- Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
- Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
- Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
- Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.
A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.
Functions
public
109
State variables
public
29
Total lines
of code
997
Capabilities
Hover on items
Audit Details
Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to speciïŹcation and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.
Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.
medium Issues
Pending
#1 Issue
Weak PRNG (weak-prng)
L928-933
Instead of implementing a random function in the contract which is predictable, use an external service like chainlink for randomness.
Pending
#2 Issue
EligibleAmounts will be overridden
L881-885
Instead of setting the amounts to the eligibleAmounts, add it to it because it is possible that the eligibleAmounts at index "x" didn't claim the winner amounts. If the same user will be randomly chosen again, the eligibleAmounts will be overridden instead of added.
low Issues
Pending
#1 Issue
Local variables shadowing (shadowing-local)
L977
Rename the local variables that shadow another component.
Pending
#2 Issue
Missing Zero Address Validation (missing-zero-check)
L711
L714
L713
L712
L789
L794
L799
L804
L809
L814
Check that the address is not zero.
Pending
#3 Issue
Everybody can call the buyback for any arbitrary addresses
L935
There may be someone who doesn't want to call the "buyback" function. It is recommended to prevent the buyback call for tokenId's, which is not owned by the caller himself.
informational Issues
Pending
#1 Issue
Functions that are not used (dead-code)
L49-51
L253-263
Remove unused functions.
Pending
#2 Issue
Balance check is unnecessary
L285
It is not needed to check the balance is above/equal the amount during the burning because it is already checked in the "_burn" function.
Pending
#3 Issue
Setting charityAddress twice
L718
In the constructor, the "charityAddress" is set to the msg.sender first and afterwards to the "_charityAddress"
optimization Issues
Pending
#1 Issue
Public function that could be declared external (external-function)
L95-97
L103-106
L134-136
L138-140
L142-144
L146-148
L150-154
L156-162
L164-169
L171-177
L179-198
L200-210
L212-226
L282-287
L763-766
L768-772
L774-777
L779-782
L784-787
L789-792
L794-797
L799-802
L804-807
L809-812
L814-817
L819-827
L829-834
L837-863
L904-906
L935-958
L960-962
L964-971
L973-975
L977-996
Use the `external` attribute for functions never called from the contract.
Disclaimer
SolidProof.io reports are not, nor should be considered, an âendorsementâ or âdisapprovalâ of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any âproductâ or âassetâ created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etcâ...)
SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.
SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProofâs position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.