Wealth Mountain
Wealth Mountain is backed by a diversified investment wallet that continuously generates yield using a variety of earning vehicles. As the protocol gains adoption and more stakes / unstakes take place, the investment wallet yield will disproportionately increase eventually reaching a point where more yield is earned by the protocol than is paid out. While maintaining safe investment vehicles for backing, the diversification wallet will also be used to support other platforms in the space! Community votes will be enabled eventually to vote on which protocol you'd like Wealth Mountain to support.
Owner privileges
Comments
- If you only use one variable in a mapping you can create one variable for the "Main" struct instead of using "MainKey[1]" constantly
- Stake fees are going to the owner's wallet in L249
- We recommend you to implement a delay of 24 hour between staking/withdrawing because of multicall contracts like MEV Bots
Audit Scope
This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.
We will verify the following claims:- Correct implementation of Token standard
- Deployer cannot mint any new tokens
- Deployer cannot burn or lock user funds
- Deployer cannot pause the contract
- Overall checkup (Smart Contract Security)
- Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
- Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
- Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
- Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
- Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
- Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
- Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.
A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.
Functions
public
14
State variables
public
7
Total lines
of code
473
Capabilities
Hover on items
Audit Details
Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to speciïŹcation and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.
Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.
medium Issues
Pending
#1 Issue
Logic will not work properly
L347
L361
"currDays >= FeesKey[40].daysInSeconds && currDays < FeesKey[50].daysInSeconds" L347 will never be executed because feesKey with the index 50 does not exist. That means in this case that calling the value "FeesKey[50].daysInSeconds" will be 0 and in the condition above the "currDays" will never below 0. "currDays >= FeesKey[50].daysInSeconds" L361 will be called everytime after the conditions before because "currDays" is above 0. In this case the "else" condition in L375 will never be executed. In this scenario the 40 days will be skipped and the 50+ days will be called every time.
informational Issues
Pending
#1 Issue
Functions that are not used (dead-code)
L30-32
L36-38
L53-55
L56-60
L45-47
L48-52
L25-29
L93-101
L106-113
L102-105
L122-126
Remove unused functions.
Pending
#2 Issue
Address zero was not excluded
L229-235
Instead of checking the "ref" is dead address, you can write the following lines instead to save some lines of codes: if (ref != 0x000000000000000000000000000000000000dEaD){ user2.refBonus += refAmtx; user.refBonus += refAmtx; } Keep in mind, that there the zero address is not excluded from the ref bonus.
Pending
#3 Issue
Unnecessary payable key
L212
Function is not using the "msg.value" in the function. Remove the "payable" key.
Pending
#4 Issue
Unused parameter
L408
L259
Remove unused parameter name - "totalWithdrawable" - "withdrawAmount"
Pending
#5 Issue
Error message is missing
-
We recommend you to provide error messages for your "require" statements because it informs the investor what happened while the error occurs
optimization Issues
Pending
#1 Issue
State variables that could be declared constant (constable-states)
L186
L185
Add the `constant` attributes to state variables that never change.
Pending
#2 Issue
Public function that could be declared external (external-function)
L212-250
L259-274
L276-379
L380-386
L388-406
L448-472
Use the `external` attribute for functions never called from the contract.
Pending
#3 Issue
Static variables
L223
Use the variable "percentdiv" instead of hardcoded numbers
Diagrams
Disclaimer
SolidProof.io reports are not, nor should be considered, an âendorsementâ or âdisapprovalâ of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any âproductâ or âassetâ created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etcâ...)
SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.
SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProofâs position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.