Owner privileges
Comments
The owner can:
- Withdraw the tokens from the SwapHelper contract
- Approve any token address for a certain amount
- Exempt fee receiver address and Remove accounts from fees mapping
- Set Developing wallets
- Set buy back and hold amount/address (also with decimals)
- Buy back and burn with/without decimals
- Set WBNB Token Pair
- Set WBNB/BUSD Pair
- Grant permission to other accounts for the following roles: "Admin", "Financial", "Controller", and "Operator"
- The wallets with admin permission can; withdraw tokens from the contract and approve other tokens.
- Due to the Authorized contract, there will be an admin in the contract even after renouncing the ownership because there can be multiple authorities controlling the contract. Moreover, only the wallets with 'admin' permission can revoke the role
Renouncing ownership will not affect the admin privileges of the wallets and there can be 'n' number of wallets that can be authorized for admin and other privileges because there is no protection from it. Thus, there is no maximum number of wallets that can have multiple authorizations over the contract.
Audit Scope
This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.
We will verify the following claims:- Correct implementation of Token standard
- Deployer cannot mint any new tokens
- Deployer cannot burn or lock user funds
- Deployer cannot pause the contract
- Overall checkup (Smart Contract Security)
- Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
- Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
- Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
- Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
- Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
- Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
- Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.
A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.
Functions
public
6
State variables
public
2
Total lines
of code
54
Capabilities
Hover on items
Functions
public
0
State variables
public
0
Total lines
of code
23
Capabilities
Hover on items
Functions
public
11
State variables
public
0
Total lines
of code
355
Capabilities
Hover on items
Functions
public
6
State variables
public
0
Total lines
of code
81
Capabilities
Hover on items
Functions
public
3
State variables
public
0
Total lines
of code
27
Capabilities
Hover on items
Functions
public
2
State variables
public
0
Total lines
of code
10
Capabilities
Hover on items
Functions
public
3
State variables
public
0
Total lines
of code
71
Capabilities
Hover on items
Functions
public
0
State variables
public
0
Total lines
of code
66
Capabilities
Hover on items
Functions
public
2
State variables
public
0
Total lines
of code
14
Capabilities
Hover on items
Functions
public
18
State variables
public
10
Total lines
of code
319
Capabilities
Hover on items
Audit Details
Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to specification and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.
Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.
low Issues
Pending
#1 Issue
Missing Zero Address Validation (missing-zero-check)
L65
L66,180,182
L314
L315
Check that the address is not zero.
Pending
#2 Issue
State variables shadowing (shadowing-state)
L17
L18
Remove the state variable shadowing.
Pending
#3 Issue
Missing Events
All
Emit events for critical parameter changes. There are no events in the contract
Pending
#4 Issue
Floating Pragma
L3
LExists in all Files
The current pragma Solidity directive is “^0.8.15". Contracts should be deployed with the same compiler version and flag that they have been tested thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using other versions.
Pending
#5 Issue
Contract doesn’t import npm packages from source (like OpenZeppelin etc.)
-
We recommend importing all packages from npm directly without flattening the contract. Functions could be modified or can be susceptible to vulnerabilities
Pending
#6 Issue
Admin can drain tokens
L33
Owner/Wallets with admin permission can withdraw the native tokens from the contract
Pending
#7 Issue
Owner can drain tokens
L13
Owner can also withdraw the native tokens from the contract
informational Issues
Pending
#1 Issue
Functions that are not used (dead-code)
L20-22
L20-22
Remove unused functions.
Pending
#2 Issue
Functions that are not used (dead-code)
L39-50
Remove unused functions.
Pending
#3 Issue
Functions that are not used (dead-code)
L274-289
L251-261
Remove unused functions.
Pending
#4 Issue
Unused state variables (unused-state)
L13
Remove unused state variables.
Pending
#5 Issue
Unused return values (unused-return)
L29-31
L29-31
Ensure that all the return values of the function calls are used.
optimization Issues
Pending
#1 Issue
Public function that could be declared external (external-function)
L53-55
L61-64
Use the `external` attribute for functions never called from the contract.
Pending
#2 Issue
Public function that could be declared external (external-function)
L61
L62
L65
L66
Use the `external` attribute for functions never called from the contract.
Pending
#3 Issue
Public function that could be declared external (external-function)
L61-63
L69-71
L86-88
L93-95
L100-102
L112-115
L120-122
L131-134
L149-163
L177-180
L196-204
Use the `external` attribute for functions never called from the contract.
Diagrams
Disclaimer
SolidProof.io reports are not, nor should be considered, an “endorsement” or “disapproval” of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any “product” or “asset” created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etc’...)
SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.
SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProof’s position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.