Rocketverse
RocketVerse arena is an FPS based on the RocketVerse universe. Our universe has characters such as humanoids, robots and aliens. You will be able to earn RKV by killing enemies, in single player, co op or multiplayer. In addition, we will have an innovative mode, Crypto deathmatch where RKV is bet at each match. The winner gets all the RKV that comes into play.
Owner privileges
Comments
Ownership Privileges:
The contract can have multiple authorities because there are three modifiers named "onlyOwner", "authorized", "onlyToken".
The onlyToken modifier is misleading because there is no check if the value of the "_token" set at the time of deployment is actually a contract address or a wallet address.
The owner can set the maximum wallet percentage as zero and lock user funds.
The owner can enable/disable cooldown, transfer ownership, and authorize/unauthorize new accounts to perform certain actions like:
- Set timelock exempt, Trigger manual buyback, and clearBuybackMultiplier
- Set auto buy-back settings to manipulate the cap, amount, period, and multiplier to any value because there are no limits or ranges.
- Set max transaction limit but not less than the desired limit
- Set max sell limit percent but not zero. Although, it can be set to any value greater than zero.
- Exempt wallets from dividends, fees, and maximum transactions.
- Set buy/sell fees as 100% or more, and fee receiver address.
- Set swap back settings and target liquidity to any amount, even zero, and to the max value of uint
- Send the contract balance manually to the marketing fee receiver address, which is again controlled by the "authorized" wallets.
- Set distributor setting and distribution criteria to any period. For example, the minimum period can be the same as the maximum or they both can be zero, and they can be changed anytime.
The Contract/Wallet address that is set under the "onlyToken" modifier can do the following changes:
-
Set distribution criteria to any period. For example, the minimum period can be the same as the maximum or they can be both zero, and they can be changed anytime.
-
Set shares for the shareholder. For example, the person controlling the "_token" address can allocate as many tokens as a dividend to any arbitrary account/wallet
-
Deposit tokens into the contract and call the process function
-
Claim dividend for any share holder.
Audit Scope
This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.
We will verify the following claims:- Correct implementation of Token standard
- Deployer cannot mint any new tokens
- Deployer cannot burn or lock user funds
- Deployer cannot pause the contract
- Overall checkup (Smart Contract Security)
- Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
- Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
- Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
- Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
- Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
- Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
- Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.
A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.
Functions
public
72
State variables
public
20
Total lines
of code
866
Capabilities
Hover on items
Audit Details
Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to speciïŹcation and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.
Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.
medium Issues
Pending
#1 Issue
Fees can be 100%
L790,799
The fees can be set as 100% or more by the wallets on the "authorizations" mapping. It means that if more than 1 wallet is authorized by the owner then one(or more) account can manipulate the fees anytime because they control the fee receiver addresses as well. Moreover, there is no maximum limit on the number of wallets the owner can authorize.
low Issues
Pending
#1 Issue
Missing Events Arithmetic (events-maths)
L283-286
L741-748
L750-755
L767-770
L790-797
L799-806
L813-816
L818-821
Emit an event for critical parameter changes.
Pending
#2 Issue
Missing Zero Address Validation (missing-zero-check)
L164
L493
L808
L808
Check that the address is not zero.
Pending
#3 Issue
Floating Pragma
-
The current pragma Solidity directive is â^0.8.12". Contracts should be deployed with the same compiler version and flag that they have been tested thoroughly. Locking the pragma helps to ensure that contracts do not accidentally get deployed using other versions
Pending
#4 Issue
Contract doesnât import npm packages from source (like OpenZeppelin etc.)
-
We recommend importing all packages from npm directly without flattening the contract. Functions could be modified or can be susceptible to vulnerabilities
informational Issues
Pending
#1 Issue
Functions that are not used (dead-code)
L588-593
L80-85
L69-71
L87-92
L12-18
L39-44
L46-51
L27-37
L20-25
Remove unused functions.
Pending
#2 Issue
Function initializing state variables (function-init-state)
L416
L419
L478
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Pending
#3 Issue
Unused state variables (unused-state)
L403
Remove unused state variables.
Pending
#4 Issue
Unused return values (unused-return)
L645-694
Ensure that all the return values of the function calls are used.
Disclaimer
SolidProof.io reports are not, nor should be considered, an âendorsementâ or âdisapprovalâ of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any âproductâ or âassetâ created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etcâ...)
SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.
SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProofâs position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.