Project overview - OG Predict

Type ERC20/BEP20
Language Solidity
Request date 2022/11/22
Latest Revision date 2022/11/22
Description

In today’s world, the most common alternative to football entertainment is betting. The problem with betting is that it incites football fans to greed and real losses, which is the exact opposite of what football is all about - entertainment and passion. In essence, football fans need something better to validate their passion for the game. The solution? OG Predict. OG Predict is a soccer prediction platform that gives you the opportunity to earn rewards for your prediction skills. This is not gambling in any way. There will be 10 fixtures weekly from the top 5 major leagues around the world. Users will have the chance to predict the scores of these matches in order to boost their chances on the weekly leaderboard.

Price Chart

Audit Summary

Static analysis Dynamic analysis Symbolic Execution SWC check
Network Binance Smart Chain
License & Compiler MIT / v0.8.10+commit.fc410830
Contract address 0x95863258BD28381fCdF50E9544621C0ef130b73A
No critical issues found The contract does not contain issues of high or medium criticality. This means that no known vulnerabilities were found in the source code.
Contract owner cannot mint It's not possible to mint new tokens.
Contract owner cannot blacklist addresses. It's not possible to lock user funds by blacklisting addresses.
Contract owner cannot set fees above 25% The fees can be a maximum of 25%. The contract can therefore not be locked.
Contract cannot be locked Owner can't lock any user funds.
Token cannot be burned There is no burn function within the contract.
Ownership is not renounced Contract can be manipulated by owner functions.
C
Critical
No Issues found.
H
High
No Issues found.
M
Medium
No Issues found.
L
Low
3 Issues found. 0 resolved.
I
Informational
4 Issues found. 0 resolved.
O
Optimization
2 Issues found. 0 resolved.
Comment

Anyone Can call the withdrawStuckETH function on L638 because there is no access control for calling the function and after it is called, the stuck ETH will be transferred to the following address: 0x606380038BeaA60cE5914d673BFcf4B809CEDc1C. Moreover, the same happens with the "remove_Random_Tokens" function on L630 but in this case, the tokens will be transferred to the Dev Wallet.

Ownership Privileges:

  • Update fees but cannot set more than 6%
  • Include/Exclude accounts from fees
  • Update Max Transaction Amount, Token Swap amount, and Max Wallet amount within limitations
  • Update Dev wallet and Presale address

Audit Scope

This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.

We will verify the following claims:
  • Correct implementation of Token standard
  • Deployer cannot mint any new tokens
  • Deployer cannot burn or lock user funds
  • Deployer cannot pause the contract
  • Overall checkup (Smart Contract Security)
The auditing process follows a routine series of steps:
  • Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
  • Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
  • Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
  • Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
  • Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
  • Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
  • Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.

A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.

Public functions Public state variables Total lines of code Capabilities
88 10 684

Public functions Public state variables Total lines of code Capabilities
88 10 684

Audit details

Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to speciïŹcation and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.

Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.

#1 | Missing Events Arithmetic (events-maths)
Severity Location Status
Low OGPredict.sol : 580-585, 597-601, 603-607, 609-613 Pending
Description

Emit an event for critical parameter changes.

#2 | Missing Zero Address Validation (missing-zero-check)
Severity Location Status
Low OGPredict.sol : 623 Pending
Description

Check that the address is not zero.

#3 | Contract doesn’t import npm packages from source (like OpenZeppelin etc.)
Severity Location Status
Low OGPredict.sol : - Pending
Description

We recommend importing all packages from npm directly without flattening the contract. Functions could be modified or can be susceptible to vulnerabilities

#1 | Functions that are not used (dead-code)
Severity Location Status
Informational OGPredict.sol : 117-130, 77-79, 81-83, 85-87, 89-94, 107-109, 111-115, 96-98, 100-104, 65-69, 71-75, 57-60, 474-476, 32-34, 43-48, 28-30, 24-26 Pending
Description

Remove unused functions.

#2 | Function initializing state variables (function-init-state)
Severity Location Status
Informational OGPredict.sol : 367, 368, 370, 371, 373, 374 Pending
Description

Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.

#6 | Unused state variables (unused-state)
Severity Location Status
Informational OGPredict.sol : 351, 368, 371, 374 Pending
Description

Remove unused state variables.

#7 | Uninitialized local variables (uninitialized-local)
Severity Location Status
Informational OGPredict.sol : 524 Pending
Description

Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.

#1 | State variables that could be declared constant (constable-states)
Severity Location Status
Optimization OGPredict.sol : 365, 380, 358 Pending
Description

Add the `constant` attributes to state variables that never change.

#2 | Public function that could be declared external (external-function)
Severity Location Status
Optimization OGPredict.sol : 337-340, 422-424, 426-428, 430-432, 434-436, 442-445, 447-449, 451-454, 456-460, 462-465, 467-470 Pending
Description

Use the `external` attribute for functions never called from the contract.

Diagrams

Disclaimer

SolidProof.io reports are not, nor should be considered, an “endorsement” or “disapproval” of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any “product” or “asset” created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etc’...)

SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.

SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProof’s position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.