OG Predict
In todayâs world, the most common alternative to football entertainment is betting. The problem with betting is that it incites football fans to greed and real losses, which is the exact opposite of what football is all about - entertainment and passion. In essence, football fans need something better to validate their passion for the game. The solution? OG Predict. OG Predict is a soccer prediction platform that gives you the opportunity to earn rewards for your prediction skills. This is not gambling in any way. There will be 10 fixtures weekly from the top 5 major leagues around the world. Users will have the chance to predict the scores of these matches in order to boost their chances on the weekly leaderboard.
Owner privileges
Comments
Anyone Can call the withdrawStuckETH function on L638 because there is no access control for calling the function and after it is called, the stuck ETH will be transferred to the following address: 0x606380038BeaA60cE5914d673BFcf4B809CEDc1C. Moreover, the same happens with the "remove_Random_Tokens" function on L630 but in this case, the tokens will be transferred to the Dev Wallet.
Ownership Privileges:
- Update fees but cannot set more than 6%
- Include/Exclude accounts from fees
- Update Max Transaction Amount, Token Swap amount, and Max Wallet amount within limitations
- Update Dev wallet and Presale address
Audit Scope
This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.
We will verify the following claims:- Correct implementation of Token standard
- Deployer cannot mint any new tokens
- Deployer cannot burn or lock user funds
- Deployer cannot pause the contract
- Overall checkup (Smart Contract Security)
- Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
- Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
- Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
- Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
- Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
- Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
- Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.
A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.
Functions
public
88
State variables
public
10
Total lines
of code
684
Capabilities
Hover on items
Audit Details
Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to speciïŹcation and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.
Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.
low Issues
Pending
#1 Issue
Missing Events Arithmetic (events-maths)
L580-585
L597-601
L603-607
L609-613
Emit an event for critical parameter changes.
Pending
#2 Issue
Missing Zero Address Validation (missing-zero-check)
L623
Check that the address is not zero.
Pending
#3 Issue
Contract doesnât import npm packages from source (like OpenZeppelin etc.)
-
We recommend importing all packages from npm directly without flattening the contract. Functions could be modified or can be susceptible to vulnerabilities
informational Issues
Pending
#1 Issue
Functions that are not used (dead-code)
L117-130
L77-79
L81-83
L85-87
L89-94
L107-109
L111-115
L96-98
L100-104
L65-69
L71-75
L57-60
L474-476
L32-34
L43-48
L28-30
L24-26
Remove unused functions.
Pending
#2 Issue
Function initializing state variables (function-init-state)
L367
L368
L370
L371
L373
L374
Remove any initialization of state variables via non-constant state variables or function calls. If variables must be set upon contract deployment, locate initialization in the constructor instead.
Pending
#3 Issue
Unused state variables (unused-state)
L351
L368
L371
L374
Remove unused state variables.
Pending
#4 Issue
Uninitialized local variables (uninitialized-local)
L524
Initialize all the variables. If a variable is meant to be initialized to zero, explicitly set it to zero to improve code readability.
optimization Issues
Pending
#1 Issue
State variables that could be declared constant (constable-states)
L365
L380
L358
Add the `constant` attributes to state variables that never change.
Pending
#2 Issue
Public function that could be declared external (external-function)
L337-340
L422-424
L426-428
L430-432
L434-436
L442-445
L447-449
L451-454
L456-460
L462-465
L467-470
Use the `external` attribute for functions never called from the contract.
Diagrams
Disclaimer
SolidProof.io reports are not, nor should be considered, an âendorsementâ or âdisapprovalâ of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any âproductâ or âassetâ created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etcâ...)
SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.
SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProofâs position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.