OctoLSD
OctoLSD is the first LSD LAADP (LSD Liquidity aggregation and distribution protocol), which is governed by OctoDAO and aims to unlock the great potential of LSD. By aggregating LSD assets and distributing them to various application scenarios, the LSD LAAD protocol provides a more efficient and accessible way to manage and deploy LSD assets.
Owner privileges
Comments
Ownership Privileges
- Set treasury address
- Add a new pool and set the reward token address, Reward per second to any arbitrary value. Moreover, the owner can also set the address of the staking token while adding the pool.
- The stuck tokens can be withdrawn by anyone but they will be credited to the treasury address.
Note - This Audit report consists of a security analysis of the OctoLSD smart contracts. This analysis did not include functional testing (or unit testing) of the contract’s logic. We recommend everyone to do their own research. Moreover, the IWETH interface's code that is used in the contract was not provided in the audit scope so we cannot comment on its security in any way.
Audit Scope
This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.
We will verify the following claims:- Correct implementation of Token standard
- Deployer cannot mint any new tokens
- Deployer cannot burn or lock user funds
- Deployer cannot pause the contract
- Overall checkup (Smart Contract Security)
- Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
- Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
- Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
- Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
- Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
- Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
- Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.
A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.
Functions
public
28
State variables
public
7
Total lines
of code
1165
Capabilities
Hover on items
Audit Details
Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to speciïŹcation and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.
Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.
low Issues
Pending
#1 Issue
Missing Zero Address Validation (missing-zero-check)
L893
Check that the address is not zero.
Pending
#2 Issue
Missing Timelock
L1051
There is no Timelock functionality in the contract which means the users will be able to withdraw their tokens right after the deposit
informational Issues
Pending
#1 Issue
Functions that are not used (dead-code)
L596-598
L625-631
L685-687
L695-704
L658-660
L668-677
L571-576
L19-21
L771-784
L795-806
L786-793
L808-822
L286-295
L246-248
L312-321
L263-272
L117-123
L159-164
L171-176
L142-152
L130-135
Remove unused functions.
optimization Issues
Pending
#1 Issue
Public function that could be declared external (external-function)
L77-79
L85-88
L899-902
L904-907
L914-916
Use the `external` attribute for functions never called from the contract.
Diagrams
Disclaimer
SolidProof.io reports are not, nor should be considered, an âendorsementâ or âdisapprovalâ of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any âproductâ or âassetâ created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etcâ...)
SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.
SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProofâs position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.