Owner privileges
Comments
- Anybody is able to call _updateDaily function
- Function should not start with an underscore when its not an internal function. This can confuse any investors/developers
Audit Scope
This audit covered the following files listed below with a SHA-1 Hash. The above token Team provided us with the files that needs to be tested.
We will verify the following claims:- Correct implementation of Token standard
- Deployer cannot mint any new tokens
- Deployer cannot burn or lock user funds
- Deployer cannot pause the contract
- Overall checkup (Smart Contract Security)
- Review of the specifications, sources, and instructions provided to SolidProof to make sure we understand the size, scope, and functionality of the smart contract.
- Manual review of code, which is the process of reading source code line-by-line in an attempt to identify potential vulnerabilities.
- Comparison to specification, which is the process of checking whether the code does what the specifications, sources, and instructions provided to SolidProof describe.
- Test coverage analysis, which is the process of determining whether the test cases are actually covering the code and how much code is exercised when we run those test cases.
- Symbolic execution, which is analysing a program to determine what inputs causes each part of a program to execute.
- Best practices review, which is a review of the smart contracts to improve efficiency, effectiveness, clarify, maintainability, security, and control based on the established industry and academic practices, recommendations, and research.
- Specific, itemized, actionable recommendations to help you take steps to secure your smart contracts.
A file with a different Hash has been modified, intentionally or otherwise, after the security review. A different Hash could be (but not necessarily) an indication of a changed condition or potential vulnerability that was not within the scope of this review.
Functions
public
37
State variables
public
32
Total lines
of code
1392
Capabilities
Hover on items
Audit Details
Throughout the review process, care was taken to evaluate the repository for security-related issues, code quality, and adherence to speciïŹcation and best practices. To do so, reviewed line-by-line by our team of expert pentesters and smart contract developers, documenting any issues as there were discovered.
Risk represents the probability that a certain source-threat will exploit vulnerability, and the impact of that event on the organization or system. Risk Level is computed based on CVSS version 3.0.
medium Issues
Pending
#1 Issue
Wrong Implementation of Modifier
L997,1002,1009
Remove non-reentrant from the internal function
low Issues
Pending
#1 Issue
Missing zero address validation
L1089
L1225
L1042
Check that the address is not zero.
Pending
#2 Issue
Missing events
L1298
Emit an event for critical parameter changes.
Pending
#3 Issue
Contract doesnât import npm packages from source (like OpenZeppelin etc.)
-
We recommend importing all packages from npm directly without flattening the contract. Functions could be modified or can be susceptible to vulnerabilities
Pending
#4 Issue
State variable visibility is missing
L885
We recommend to add the visibility (public, private etc.) to the state variable.
informational Issues
Pending
#1 Issue
Functions that are not used (dead-code)
L18-21
L722-724
L764-766
L820-829
L780-782
L846-855
L750-752
L736-738
L797-806
L651-657
L693-698
L705-710
L676-686
L664-669
Remove unused functions.
Pending
#2 Issue
Unused state variables (unused-state)
L891
L892
Remove unused state variables.
Pending
#3 Issue
State variables that could be declared constant (constable-states)
L292
L293
Add the `constant` attributes to state variables that never change.
Pending
#4 Issue
Naming convention for constants
L888-894
Constant variables should be uppercased. Private constants should start with an underscore with uppercased letters.
Pending
#5 Issue
Missing error messages
-
Provide an error message for any require statements.
Diagrams
Disclaimer
SolidProof.io reports are not, nor should be considered, an âendorsementâ or âdisapprovalâ of any particular project or team. These reports are not, nor should be considered, an indication of the economics or value of any âproductâ or âassetâ created by any team. SolidProof.io do not cover testing or auditing the integration with external contract or services (such as Unicrypt, Uniswap, PancakeSwap etcâ...)
SolidProof.io Audits do not provide any warranty or guarantee regarding the absolute bug- free nature of the technology analyzed, nor do they provide any indication of the technology proprietors. SolidProof Audits should not be used in any way to make decisions around investment or involvement with any particular project. These reports in no way provide investment advice, nor should be leveraged as investment advice of any sort.
SolidProof.io Reports represent an extensive auditing process intending to help our customers increase the quality of their code while reducing the high level of risk presented by cryptographic tokens and blockchain technology. Blockchain technology and cryptographic assets present a high level of ongoing risk. SolidProofâs position is that each company and individual are responsible for their own due diligence and continuous security. SolidProof in no way claims any guarantee of security or functionality of the technology we agree to analyze.