Harbor Finance Info
Harbor Finance is a high-performance, gamified DeFi ecosystem that seamlessly merges NFT-based asset structures, sustainable passive income strategies, and immersive financial gameplay. Our mission: to make automated earning not just simple, but genuinely enjoyable. Engineer intricate Yield Items. Harvest $FISH. Collect ongoing incentives. Rise through the ranks as a master-class Fishercat.
TrustNet Score
The TrustNet Score evaluates crypto projects based on audit results, security, KYC verification, and social media presence. This score offers a quick, transparent view of a project's credibility, helping users make informed decisions in the Web3 space.
Real-Time Threat Detection
Real-time threat detection, powered by Cyvers.io,
is currently not
activated
for this project.
This advanced feature provides continuous monitoring and instant alerts to safeguard your assets from potential security threats. Real-time detection enhances your project's security by proactively identifying and mitigating risks.
For more information, click here.
Security Assessments
Summary and Final Words
No crucial issues found
The contract does not contain issues of high or medium criticality. This means that no known vulnerabilities were found in the source code.
Contract owner cannot mint
It is not possible to mint new tokens.
Contract owner cannot blacklist addresses.
It is not possible to lock user funds by blacklisting addresses.
Contract owner cannot set high fees
The fees, if applicable, can be a maximum of 25% or lower. The contract can therefore not be locked. Please take a look in the comment section for more details.
Contract cannot be locked
Owner cannot lock any user funds.
Token cannot be burned
There is no burning within the contract without any allowances
Ownership is not renounced
The owner retains significant control, which could potentially be used to modify key contract parameters.
Contract is not upgradeable
The contract does not use proxy patterns or other mechanisms to allow future upgrades. Its behavior is locked in its current state.
Scope of Work
This audit encompasses the evaluation of the files listed below, each verified with a SHA-1 Hash. The team referenced above has provided the necessary files for assessment.
The auditing process consists of the following systematic steps:
- Specification Review: Analyze the provided specifications, source code, and instructions to fully understand the smart contract's size, scope, and functionality.
- Manual Code Examination: Conduct a thorough line-by-line review of the source code to identify potential vulnerabilities and areas for improvement.
- Specification Alignment: Ensure that the code accurately implements the provided specifications and intended functionalities.
- Test Coverage Assessment: Evaluate the extent and effectiveness of test cases in covering the codebase, identifying any gaps in testing.
- Symbolic Execution: Analyze the smart contract to determine how various inputs affect execution paths, identifying potential edge cases and vulnerabilities.
- Best Practices Evaluation: Assess the smart contracts against established industry and academic best practices to enhance efficiency, maintainability, and security.
- Actionable Recommendations: Provide detailed, specific, and actionable steps to secure and optimize the smart contracts.
A file with a different Hash has been intentionally or otherwise modified after the security review. A different Hash may indicate a changed condition or potential vulnerability that was not within the scope of this review.
Final Words
The following provides a concise summary of the audit report, accompanied by insightful comments from the auditor. This overview captures the key findings and observations, offering valuable context and clarity.
Ownership Privileges
FishingNet.sol
- The DEFAULT_ADMIN_ROLE can grant/revoke all other roles.
- The ADMIN_ROLE can update contract addresses (updateReferralSystem, updateTerritoryRegistry, updateFishToken, updateEarlyToken, updateEarlyTokenRedeemer).
- The ADMIN_ROLE can update pricing (updatePrice) and territory configurations (updateRequiredNets, updateMaxClaim, configureNewTerritoryType).
- The ADMIN_ROLE can mint new fishing nets directly (mint).
- The BURNER_ROLE can consume fishing nets when players claim rewards (consumeNets).
- Any user can purchase fishing nets (purchaseNets).
Note - This Audit report consists of a security analysis of the Harbor smart contract. This analysis did not include functional testing (or unit testing) of the contract’s logic. Moreover, we only audited the mentioned contract for the Harbor team. Other contracts associated with the project were not audited by our team. We recommend investors do their own research before investing.
Files and details
Findings and Audit result
medium Issues | 3 findings
Resolved
#1 medium Issue
The pauser role can pause the token transfer for an indefinite period.
FishingNet implements a highly centralized pause mechanism that creates significant security and economic risks. The PAUSER_ROLE can unilaterally and instantly freeze all token transfers across the entire ecosystem without warning, justification, or community approval. This represents a single point of failure that could severely disrupt the game economy, locking user assets and preventing time-sensitive transactions. If compromised, this role could be weaponized to cause maximum economic damage.
Resolved
#2 medium Issue
Missing 'isContract' check.
The contract lacks a validation check to ensure that specific parameters are contract addresses. Without this check, there is a risk that non-contract addresses (such as externally owned accounts, or EOAs) could be mistakenly set for parameters intended to reference other contracts. This could lead to failures in executing critical interactions within the contract, as EOAs do not support contract-specific functions.
Resolved
#3 medium Issue
The minter can mint unlimited tokens.
FishingNet implements a mint function with no restrictions on amount or frequency, controlled solely by MINTER_ROLE. This allows privileged addresses to mint unlimited tokens to any recipient, potentially enabling supply manipulation, token value dilution, and economic imbalance within the game ecosystem. The absence of supply caps, rate limits, or oversight mechanisms creates a significant centralization risk and single point of failure that could destabilize the entire economy if compromised or misused.
low Issues | 2 findings
Acknowledged
#1 low Issue
Missing BURNER_ROLE Assignment in FishingNet Constructor
The FishingNet contract defines a BURNER_ROLE that controls access to the critical consumeNets() function, which is essential for the game's reward claiming mechanics. However, the constructor fails to assign this role to any address, including the admin. This creates a post-deployment vulnerability where the core consumption functionality remains completely inaccessible until an admin manually grants the role, risking permanent functionality loss if admin access is compromised before this step is completed.
Resolved
#2 low Issue
Missing Upper Limit for Purchase Amount in FishingNet Contract
The purchaseNets function lacks any upper bound on the amount parameter, allowing users to purchase an unlimited number of Fishing Nets in a single transaction. With no maximum limit check before calculating the total cost, users can mint an arbitrarily large quantity of nets, potentially disrupting the game's economic balance. This unbounded minting capability contradicts standard GameFi design principles where consumable resources should have controlled distribution mechanisms to maintain ecosystem stability.
informational Issues | 1 findings
Acknowledged
#1 informational Issue
Floating pragma solidity version
Adding the constant version of solidity is recommended, as this prevents the unintentional deployment of a contract with an outdated compiler that contains unresolved bugs.