Harbor Finance Info
Harbor Finance is a high-performance, gamified DeFi ecosystem that seamlessly merges NFT-based asset structures, sustainable passive income strategies, and immersive financial gameplay. Our mission: to make automated earning not just simple, but genuinely enjoyable. Engineer intricate Yield Items. Harvest $FISH. Collect ongoing incentives. Rise through the ranks as a master-class Fishercat.
TrustNet Score
The TrustNet Score evaluates crypto projects based on audit results, security, KYC verification, and social media presence. This score offers a quick, transparent view of a project's credibility, helping users make informed decisions in the Web3 space.
Real-Time Threat Detection
Real-time threat detection, powered by Cyvers.io,
is currently not
activated
for this project.
This advanced feature provides continuous monitoring and instant alerts to safeguard your assets from potential security threats. Real-time detection enhances your project's security by proactively identifying and mitigating risks.
For more information, click here.
Security Assessments
Summary and Final Words
No crucial issues found
The contract does not contain issues of high or medium criticality. This means that no known vulnerabilities were found in the source code.
Contract owner cannot mint
It is not possible to mint new tokens.
Contract owner cannot blacklist addresses.
It is not possible to lock user funds by blacklisting addresses.
Contract owner cannot set high fees
The fees, if applicable, can be a maximum of 25% or lower. The contract can therefore not be locked. Please take a look in the comment section for more details.
Contract cannot be locked
Owner cannot lock any user funds.
Token cannot be burned
There is no burning within the contract without any allowances
Ownership is not renounced
The owner retains significant control, which could potentially be used to modify key contract parameters.
Contract is not upgradeable
The contract does not use proxy patterns or other mechanisms to allow future upgrades. Its behavior is locked in its current state.
Scope of Work
This audit encompasses the evaluation of the files listed below, each verified with a SHA-1 Hash. The team referenced above has provided the necessary files for assessment.
The auditing process consists of the following systematic steps:
- Specification Review: Analyze the provided specifications, source code, and instructions to fully understand the smart contract's size, scope, and functionality.
- Manual Code Examination: Conduct a thorough line-by-line review of the source code to identify potential vulnerabilities and areas for improvement.
- Specification Alignment: Ensure that the code accurately implements the provided specifications and intended functionalities.
- Test Coverage Assessment: Evaluate the extent and effectiveness of test cases in covering the codebase, identifying any gaps in testing.
- Symbolic Execution: Analyze the smart contract to determine how various inputs affect execution paths, identifying potential edge cases and vulnerabilities.
- Best Practices Evaluation: Assess the smart contracts against established industry and academic best practices to enhance efficiency, maintainability, and security.
- Actionable Recommendations: Provide detailed, specific, and actionable steps to secure and optimize the smart contracts.
A file with a different Hash has been intentionally or otherwise modified after the security review. A different Hash may indicate a changed condition or potential vulnerability that was not within the scope of this review.
Final Words
The following provides a concise summary of the audit report, accompanied by insightful comments from the auditor. This overview captures the key findings and observations, offering valuable context and clarity.
Ownership Privileges
FuelSystem.sol
- The DEFAULT_ADMIN_ROLE can grant/revoke all other roles in the system.
- The ADMIN_ROLE can update the referral system address (updateReferralSystem).
- The ADMIN_ROLE can add fuel to user accounts (addFuel).
- The ADMIN_ROLE can update fuel parameters (updateFuelParameters).
- The ADMIN_ROLE can update action costs (updateActionCosts).
- The ADMIN_ROLE can set the treasury address (setTreasury).
- The ADMIN_ROLE can set the team address (setTeam).
- The ADMIN_ROLE can pause/unpause the contract (pause, unpause).
- The ADMIN_ROLE can rescue HYPE tokens from the contract (rescueHype).
- The ADMIN_ROLE can open/close fuel purchases (setPurchaseOpen).
- The CONSUMER_ROLE can consume fuel for staking actions (consumeFuelForStaking).
- The CONSUMER_ROLE can consume fuel for claim actions (consumeFuelForClaim).
- The CONSUMER_ROLE can consume fuel for generic actions (consumeFuel).
Note - This Audit report consists of a security analysis of the Harbor smart contract. This analysis did not include functional testing (or unit testing) of the contract’s logic. Moreover, we only audited the mentioned contract for the Harbor team. Other contracts associated with the project were not audited by our team. We recommend investors do their own research before investing.
Files and details
Findings and Audit result
medium Issues | 3 findings
Resolved
#1 medium Issue
Missing 'isContract' check.
The contract lacks a validation check to ensure that specific parameters are contract addresses. Without this check, there is a risk that non-contract addresses (such as externally owned accounts, or EOAs) could be mistakenly set for parameters intended to reference other contracts. This could lead to failures in executing critical interactions within the contract, as EOAs do not support contract-specific functions.
Resolved
#2 medium Issue
Integer Division Precision Loss in Fuel Regeneration Calculation
The FuelSystem contract's fuel regeneration mechanism contains a critical mathematical flaw in the _calculateCurrentFuel function. When converting the hourly regeneration rate to per-second rate, it performs integer division (fuelRegenerationRate / 3600) which results in zero for any regeneration rate less than 3600. With the default setting of 25 fuel per hour, this division yields 0, causing all fuel regeneration calculations to result in zero regardless of time passed. This effectively breaks the core regeneration mechanic, preventing users from naturally recovering fuel over time and forcing them to purchase fuel instead.
Resolved
#3 medium Issue
Missing Parameter Validation in updateActionCosts Function
The updateActionCosts function allows the admin to update critical gameplay parameters (stakingFuelCost and claimFuelCost) without any minimum or maximum thresholds. The function accepts any uint256 values, allowing costs to be set from 0 (free actions) to the maximum uint256 value (effectively disabling functionality). This unlimited parameter range creates significant economic governance risks, as the admin could suddenly change action costs to extreme values, potentially breaking game balance and disrupting player expectations. Players have no in-contract guarantees that fuel costs will remain within reasonable, playable bounds.
low Issues | 1 findings
Acknowledged
#1 low Issue
Missing CONSUMER_ROLE Assignment in FuelSystem Constructor
The FuelSystem contract defines a CONSUMER_ROLE that is required to call critical gameplay functions including consumeFuelForStaking, consumeFuelForClaim, and consumeFuel. However, the constructor fails to assign this role to any address, including the admin. This creates a post-deployment vulnerability where core fuel consumption functionality remains completely inaccessible until an admin manually grants the role. If admin access is compromised before this role is assigned, the fuel consumption mechanics would be permanently disabled.
optimization Issues | 1 findings
Acknowledged
#1 optimization Issue
Inefficient Regeneration Calculation for Frequent Callers
The FuelSystem contract's _calculateCurrentFuel function performs complete regeneration calculations on every invocation, regardless of call frequency. When multiple calls occur within short timeframes (same block or seconds apart), the contract repeatedly executes the same calculations despite minimal or zero changes in the regenerated fuel amount. This inefficiency causes unnecessary gas consumption during frequent interactions, such as UI refreshes, failed transaction retries, or multi-step game actions. The issue particularly impacts active players and integrated contracts that may check fuel levels multiple times in rapid succession, forcing users to pay for redundant computation.
informational Issues | 2 findings
Acknowledged
#1 informational Issue
Floating pragma solidity version
Adding the constant version of solidity is recommended, as this prevents the unintentional deployment of a contract with an outdated compiler that contains unresolved bugs.
Resolved
#2 informational Issue
Missing emit.
It is recommended to emit all the parameter changes.